ref(analytics): Transform analytics events for TET-827 #95207

constantinius · 2025-07-10T09:13:08Z

Transform event classes to use @analytics.eventclass decorator
Transform analytics.record calls to use event class instances
Update imports as needed

Closes TET-827

- Transform event classes to use @analytics.eventclass decorator - Transform analytics.record calls to use event class instances - Update imports as needed Closes TET-827

codecov · 2025-07-10T09:28:56Z

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
27218	2	27216	243

View the top 2 failed test(s) by shortest run time

tests.sentry.api.helpers.test_group_index.ValidateSearchFilterPermissionsTest::test_negative

Stack Traces | 1.28s run time

#x1B[1m#x1B[.../api/helpers/test_group_index.py#x1B[0m:64: in test_negative
    self.assert_analytics_recorded(mock_record)
#x1B[1m#x1B[.../api/helpers/test_group_index.py#x1B[0m:47: in assert_analytics_recorded
    mock_record.assert_called_with(
#x1B[1m#x1B[.../hostedtoolcache/Python/3.13.1.../x64/lib/python3.13/unittest/mock.py#x1B[0m:977: in assert_called_with
    raise AssertionError(_error_message()) from cause
#x1B[1m#x1B[31mE   AssertionError: expected call not found.#x1B[0m
#x1B[1m#x1B[31mE   Expected: record('advanced_search.feature_gated', user_id=210, default_user_id=210, organization_id=4556398608973824)#x1B[0m
#x1B[1m#x1B[31mE     Actual: record(AdvancedSearchFeatureGateEvent(uuid_=UUID('dd678f3e-5e69-11f0-b894-00224823d8ed'), datetime_=datetime.datetime(2025, 7, 11, 15, 15, 23, 786874, tzinfo=datetime.timezone.utc), user_id='210', default_user_id='210', organization_id='4556398608973824'))#x1B[0m

tests.sentry.api.helpers.test_group_index.ValidateSearchFilterPermissionsTest::test_wildcard

Stack Traces | 1.32s run time

#x1B[1m#x1B[.../api/helpers/test_group_index.py#x1B[0m:86: in test_wildcard
    self.assert_analytics_recorded(mock_record)
#x1B[1m#x1B[.../api/helpers/test_group_index.py#x1B[0m:47: in assert_analytics_recorded
    mock_record.assert_called_with(
#x1B[1m#x1B[.../hostedtoolcache/Python/3.13.1.../x64/lib/python3.13/unittest/mock.py#x1B[0m:977: in assert_called_with
    raise AssertionError(_error_message()) from cause
#x1B[1m#x1B[31mE   AssertionError: expected call not found.#x1B[0m
#x1B[1m#x1B[31mE   Expected: record('advanced_search.feature_gated', user_id=257, default_user_id=257, organization_id=4556398611857408)#x1B[0m
#x1B[1m#x1B[31mE     Actual: record(AdvancedSearchFeatureGateEvent(uuid_=UUID('f77b8b8c-5e69-11f0-b894-000d3a352aa2'), datetime_=datetime.datetime(2025, 7, 11, 15, 16, 7, 665572, tzinfo=datetime.timezone.utc), user_id='257', default_user_id='257', organization_id='4556398611857408'))#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

cursor

Bug: Missing User ID in Integration Comments Sync Event

The IntegrationIssueCommentsSyncedEvent analytics call in src/sentry/integrations/tasks/create_comment.py and src/sentry/integrations/tasks/update_comment.py no longer captures the user_id parameter. This is because the user_id field was removed from the IntegrationIssueCommentsSyncedEvent class, leading to a loss of user tracking data that was previously captured and may impact downstream analytics consumers.

src/sentry/integrations/tasks/create_comment.py#L70-L77

sentry/src/sentry/integrations/tasks/create_comment.py

Lines 70 to 77 in 4867cdb

    
           note.save() 
        
           analytics.record( 
        
               IntegrationIssueCommentsSyncedEvent( 
        
                   provider=installation.model.provider, 
        
                   id=installation.model.id, 
        
                   organization_id=external_issue.organization_id, 
        
               ) 
        
           )

src/sentry/integrations/tasks/update_comment.py#L70-L77

sentry/src/sentry/integrations/tasks/update_comment.py

Lines 70 to 77 in 4867cdb

    
           installation.update_comment(external_issue.key, user_id, note) 
        
           analytics.record( 
        
               IntegrationIssueCommentsSyncedEvent( 
        
                   provider=installation.model.provider, 
        
                   id=installation.model.id, 
        
                   organization_id=external_issue.organization_id, 
        
               ) 
        
           )

Fix in Cursor • Fix in Web

Bug: Event ID Type Mismatch Causes Serialization Errors

The id field in IntegrationResolvePREvent is incorrectly typed as str. It should be int to match the repo.integration_id value passed to it, which is an integer database ID. This also creates an inconsistency with IntegrationResolveCommitEvent.id, which is correctly typed as int and uses the same value. This type mismatch can lead to runtime errors or data serialization issues.

src/sentry/integrations/analytics.py#L74-L79

sentry/src/sentry/integrations/analytics.py

Lines 74 to 79 in 4867cdb

    
           @analytics.eventclass("integration.resolve.pr") 
        
           class IntegrationResolvePREvent(analytics.Event): 
        
               provider: str | None 
        
               id: str 
        
               organization_id: str

Fix in Cursor • Fix in Web

Bug: Type Mismatch in Analytics Event IDs

Analytics event classes define organization_id, project_id, and group_id as str. However, these fields are consistently populated with integer IDs from model objects (e.g., project.id, group.id), leading to type mismatches and errors.

src/sentry/analytics/events/first_new_feedback_sent.py#L5-L7

sentry/src/sentry/analytics/events/first_new_feedback_sent.py

Lines 5 to 7 in 4867cdb

    
           class FirstNewFeedbackSentEvent(analytics.Event): 
        
               organization_id: str 
        
               project_id: str

src/sentry/analytics/events/first_sourcemaps_sent.py#L6-L11

sentry/src/sentry/analytics/events/first_sourcemaps_sent.py

Lines 6 to 11 in 4867cdb

    
           user_id: int 
        
           organization_id: str 
        
           project_id: str 
        
           platform: str | None = None 
        
           url: str | None = None 
        
           project_platform: str | None = None

src/sentry/analytics/events/issue_deleted.py#L5-L11

sentry/src/sentry/analytics/events/issue_deleted.py

Lines 5 to 11 in 4867cdb

    
           class IssueDeletedEvent(analytics.Event): 
        
               group_id: str 
        
               delete_type: str 
        
               organization_id: str 
        
               project_id: str 
        
               user_id: str | None = None 
        
               default_user_id: str

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

ref(analytics): Transform analytics events for TET-827

e0fe946

- Transform event classes to use @analytics.eventclass decorator - Transform analytics.record calls to use event class instances - Update imports as needed Closes TET-827

constantinius requested review from a team as code owners July 10, 2025 09:13

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 10, 2025

vercel bot deployed to Preview July 10, 2025 09:14 View deployment

This comment was marked as outdated.

Sign in to view

Merge branch 'master' into constantinius/ref/analytics/tet-827

fb47d22

vercel bot deployed to Preview July 11, 2025 07:27 View deployment

This comment was marked as outdated.

Sign in to view

Merge branch 'master' into constantinius/ref/analytics/tet-827

93baae2

vercel bot deployed to Preview July 11, 2025 13:41 View deployment

This comment was marked as outdated.

Sign in to view

constantinius added 6 commits July 11, 2025 16:25

test(analytics): add assert_last_analytics_event for testing

2c18bc1

test(analytics): fix testing analytics in onboarding

9746ca6

test(analytics): fix testing analytics in test_signals

e8b551f

test(analytics): fix tests in test_organization_group_index

a68628d

test(analytics) fix tests in test_issues

063d3b3

fix(analytics): mypy type issues

4867cdb

vercel bot deployed to Preview July 11, 2025 15:11 View deployment

cursor bot reviewed Jul 11, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

ref(analytics): Transform analytics events for TET-827 #95207

ref(analytics): Transform analytics events for TET-827 #95207

Uh oh!

constantinius commented Jul 10, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

codecov bot commented Jul 10, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

	note.save()
	analytics.record(
	IntegrationIssueCommentsSyncedEvent(
	provider=installation.model.provider,
	id=installation.model.id,
	organization_id=external_issue.organization_id,
	)
	)

	installation.update_comment(external_issue.key, user_id, note)
	analytics.record(
	IntegrationIssueCommentsSyncedEvent(
	provider=installation.model.provider,
	id=installation.model.id,
	organization_id=external_issue.organization_id,
	)
	)


	@analytics.eventclass("integration.resolve.pr")
	class IntegrationResolvePREvent(analytics.Event):
	provider: str \| None
	id: str
	organization_id: str

	class FirstNewFeedbackSentEvent(analytics.Event):
	organization_id: str
	project_id: str

	user_id: int
	organization_id: str
	project_id: str
	platform: str \| None = None
	url: str \| None = None
	project_platform: str \| None = None

	class IssueDeletedEvent(analytics.Event):
	group_id: str
	delete_type: str
	organization_id: str
	project_id: str
	user_id: str \| None = None
	default_user_id: str

Uh oh!

ref(analytics): Transform analytics events for TET-827 #95207

Are you sure you want to change the base?

ref(analytics): Transform analytics events for TET-827 #95207

Uh oh!

Conversation

constantinius commented Jul 10, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

codecov bot commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 2 Tests Failed:

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Missing User ID in Integration Comments Sync Event

Bug: Event ID Type Mismatch Causes Serialization Errors

Bug: Type Mismatch in Analytics Event IDs

Uh oh!

Uh oh!

codecov bot commented Jul 10, 2025 •

edited

Loading